Page 1 of 1

blog_list issue

Posted: Wed Dec 07, 2011 5:50 am
by guitardude211
Hello again!

I am having an issue with the content showing up on my blog_list for the "Test post" and every thing else

here are the two files in code:
"posts.inc.php"
<?php

//checks if the given post id is in the table
function valid_pid($pid) {
	$pid = (int)$pid;
	
	$total = mysql_query("SELECT COUNT(`post_id`) FROM `posts` WHERE `post_id` = {$pid}");
	$total = mysql_result($total, 0);
	
	if ($total != 1) {
		return false;
	}else{
		return true;
	}
}

//gets a summary of all blog posts
function get_posts() {
	$sql = "SELECT
				`posts`.`post_id` AS `id`,
				`posts`.`post_title` AS `title`,
				LEFT(`posts`.`post_body`, 512) AS `preview`,
				`posts`.`post_user` AS `user`,
				DATE_FORMAT(`posts`.`post_date`, '%d-%m-%Y %H:%i:%s') AS `date`,
				`comments`.`total_comments`,
				DATE_FORMAT(`comments`.`last_comment`, '%d-%m-%Y %H:%i:%s') AS `last_comment`
			FROM `posts`
			LEFT JOIN(
				SELECT
					`post_id`,
					COUNT(`comment_id`) AS `total_comments`,
					MAX(`comment_date`) AS `last_comment`
				FROM `comments`
				GROUP BY `post_id`
			) AS `comments`
			ON `posts`.`post_id` = `comments`.`post_id`
			ORDER BY `posts`.`post_date` DESC";
	
	$posts = mysql_query($sql);
	
	$rows = array();
	while (($row = mysql_fetch_assoc($posts)) !== false) {
		$row[] = array(
			'id'             => $row['id'],
			'title'   	     => $row['title'],
			'preview'        => $row['preview'],
			'user'           => $row['user'],
			'date'           => $row['date'],
			'total_comments' => ($row['total_comments'] === null) ? 0 : $row['total_comments'],
			'last_comment'   => ($row['last_comment'] === null) ? 'never' : $row['last_comment']
		);
	}
	
	return $rows;
}

//gets a single post from the table
function get_post($pid) {
	$pid = (int)$pid;
	
	$sql = "SELECT
				`post_title` AS `title`,
				`post_body` AS `body`,
				`post_user` AS `user,
				`post_date` AS `date`
			FROM `posts`
			WHERE `post_id` = {$pid}";
	
	$post = mysql_query($sql);
	$post = mysql_fetch_assoc($post);
	
	$post['comments'] = get_comments($pid);
	
	return $post;
}

//adds a new blog entry
function add_post($name, $title, $body) {
	$name = mysql_real_escape_string(htmlentites($name));
	$title = mysql_real_escape_string(htmlentites($title));
	$body = mysql_real_escape_string(nl2br(htmlentites($body)));
	
	mysql_query("INSERT INTO `posts` (`post_user`, `post_title`, `post_body`, `post_date`) VALUES ('{$name}', '{$title}', '{$body}', NOW())");
}

?>
"blog_list.php"
<?php

include('core/init.inc.php');

?>
<!DOCTYPE html PUBLIC "-//WC3//DTD XHTML 1.0 Strict//EN" "http://www.w3/org/TR/xhtml1/DTD/xhtml-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
	<head>
		<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
		<title>Blog</title>
	</head>
	<body>
		<div>
			<?php
			
			$posts = get_posts();
			
			foreach($posts as $post){
				?>
				<h2><?php echo $post['title']; ?></h2>
				<h4>By <?php echo $post['user']; ?> on <?php $post['date']; ?></h4>
				<h4>(<?php echo $post['total_comments']; ?> comments, last comment <?php echo $post['last_comment']; ?>)</h4>
				
				<hr />
				
				<p><?php echo $post['preview'] ?></p>
				<?php
			}
			
			?>
		</div>
	</body>
</html>
and "comments.inc.php"
<?php

//gets all of the comments for a given blog post
function get_comments($pid){
	$pid = (int)$pid;
	
	$sql = "SELECT
				`comment_body` AS `body`,
				`comment_user` AS `user`,
				DATE_FORMAT(`comment_date`, '%d/%m/%Y %H:%i:s') AS `date`
			FROM `comments`
			WHERE `post_id` = {$pid}";
			
	$comments = mysql_query($sql);
	
	$return = array();
	while(($row = mysql_fetch_assoc($comments)) !== false) {
		$retun[] = $row;
	}
	return $return;
}

//adds a comment
function add_comment($pid, $user, $body) {
	if (valid_pid($pid) === false) {
		return false;
	}
	
	$pid 	= (int)$pid;
	$user 	= mysql_real_escape_string(htmlentites($user));
	$body 	= mysql_real_escape_string(nl2br(htmlentites($body)));
	
	mysql_query("INSERT INTO `comments` (`post_id`, `comment_user`, `comment_body`, `comments_date`) VALUES ({$pid}, '{$user}', '{$body}', NOW())");
	
	return true;
}

?>

Re: blog_list issue

Posted: Wed Dec 07, 2011 6:31 am
by Jaami
can you be more precise, please? any error/s? did you checked your db, if it gets your "Test post" correctly?

Re: blog_list issue

Posted: Wed Dec 07, 2011 7:14 am
by guitardude211
No visible errors..I guess the only error is that the content isn't getting retrieved from the database. I checked the database connection and it seems connected. I think the issue is in the get_posts()" function..I'm not sure though..

Re: blog_list issue

Posted: Wed Dec 07, 2011 7:19 am
by Temor
can you post the code for all of your files here? Including init.inc.php

Re: blog_list issue

Posted: Wed Dec 07, 2011 6:41 pm
by jacek
In the get_posts() function
$row[] = array(
You are adding each row to $row instead of $rows

Re: blog_list issue

Posted: Fri Dec 09, 2011 12:27 am
by guitardude211
thanks for pointing that out to me..I some how spaced that..however now I get an error that states
"Warning: Invalid argument supplied for foreach() in blog_list.php on line 18"

It seems to look fine to me.. :/
<?php

include('core/init.inc.php');

?>
<!DOCTYPE html PUBLIC "-//WC3//DTD XHTML 1.0 Strict//EN" "http://www.w3/org/TR/xhtml1/DTD/xhtml-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
	<head>
		<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
		<title>Blog</title>
	</head>
	<body>
		<div>
			<?php
			
			$posts = get_posts();
			
			foreach($posts as $post){
				?>
				<h2><?php echo $post['title']; ?></h2>
				<h4>By <?php echo $post['user']; ?> on <?php $post['date']; ?></h4>
				<h4>(<?php echo $post['total_comments']; ?> comments, last comment <?php echo $post['last_comment']; ?>)</h4>
				
				<hr />
				
				<p><?php echo $post['preview']; ?></p>
				<?php
			}
			
			?>
		</div>
	</body>
</html>

Re: blog_list issue

Posted: Fri Dec 09, 2011 8:59 pm
by jacek
$posts must not be an array, the problem is probably with your function again. Can you post the current code for that ?

Re: blog_list issue

Posted: Sat Dec 10, 2011 4:49 am
by guitardude211
I think this is the function you are refering to. Sorry If I did not understand..
function get_posts() {
	$sql = "SELECT
				`posts`.`post_id` AS `id`,
				`posts`.`post_title` AS `title`,
				LEFT(`posts`.`post_body`, 512) AS `preview`,
				`posts`.`post_user` AS `user`,
				DATE_FORMAT(`posts`.`post_date`, '%d-%m-%Y %H:%i:%s') AS `date`,
				`comments`.`total_comments`,
				DATE_FORMAT(`comments`.`last_comment`, '%d-%m-%Y %H:%i:%s') AS `last_comment`
			FROM `posts`
			LEFT JOIN(
				SELECT
					`post_id`,
					COUNT(`comment_id`) AS `total_comments`,
					MAX(`comment_date`) AS `last_comment`
				FROM `comments`
				GROUP BY `post_id`
			) AS `comments`
			ON `posts`.`post_id` = `comments`.`post_id`
			ORDER BY `posts`.`post_date` DESC";
	
	$posts = mysql_query($sql);
	
	$rows = array();
	while (($rows = mysql_fetch_assoc($posts)) !== false) {
		$rows[] = array(
			'id'             => $rows['id'],
			'title'   	     => $rows['title'],
			'preview'        => $rows['preview'],
			'user'           => $rows['user'],
			'date'           => $rows['date'],
			'total_comments' => ($rows['total_comments'] === null) ? 0 : $row['total_comments'],
			'last_comment'   => ($rows['last_comment'] === null) ? 'never' : $row['last_comment']
		);
	}
	
	return $rows;
}

Re: blog_list issue

Posted: Sat Dec 10, 2011 7:42 am
by Jaami
change this:
        $rows = array();
        while (($rows = mysql_fetch_assoc($posts)) !== false) {
                $rows[] = array(
                        'id'             => $rows['id'],
                        'title'              => $rows['title'],
                        'preview'        => $rows['preview'],
                        'user'           => $rows['user'],
                        'date'           => $rows['date'],
                        'total_comments' => ($rows['total_comments'] === null) ? 0 : $row['total_comments'],
                        'last_comment'   => ($rows['last_comment'] === null) ? 'never' : $row['last_comment']
                );
to this:
        $rows = array();
        while (($row = mysql_fetch_assoc($posts)) !== false) {
                $rows[] = array(
                        'id'                       => $row['id'],
                        'title'                   => $row['title'],
                        'preview'             => $row['preview'],
                        'user'                   => $row['user'],
                        'date'                   => $row['date'],
                        'total_comments' => ($row['total_comments'] === null) ? 0 : $row['total_comments'],
                        'last_comment'     => ($row['last_comment'] === null) ? 'never' : $row['last_comment']
                );

Re: blog_list issue

Posted: Sat Dec 10, 2011 1:06 pm
by jacek
To explain the above,
while (($rows = mysql_fetch_assoc($posts)) !== false) {
Your use of $rows on this line is overwriting the $rows array.

Re: blog_list issue

Posted: Sat Dec 10, 2011 11:24 pm
by guitardude211
Solved the blog_list issue! Thanks everyone!! :)