BetterPHP

Hi guys,

I just finished the blog tutorials. Apparently everything is working, but when I submit a post on the blog_post.php page, I get this error (even tho the post will be appeared on the blog_list page ).

Warning: Cannot modify header information - headers already sent by (output started at /home/*****/public_html/blog/func/inc/posts.inc.php:1) in /home/*****/public_html/blog/blog_post.php on line 7.

blog_post.php

<?php
ini_set('display_errors',1);
error_reporting(E_ALL);
include 'func/config.php';
if (isset($_POST['user'], $_POST['title'], $_POST['body'])){
        add_post($_POST['user'], $_POST['title'], $_POST['body']);
        header('Location: blog_list.php');
        die();		 
}
?>

posts.inc.php

<?php
    //checks if the given post id is in the table
    function valid_pid($pid) {
    $pid = (int)$pid;
    $total = mysql_query("SELECT COUNT(`post_id`) FROM `posts` WHERE `post_id` = {$pid}");
    $total = mysql_result($total, 0);
    if ($total != 1) {
    return false;
    }else{
    return true;
    }
    }
    //gets a summary of all blog posts
    function get_posts() {
    $sql = "SELECT
    `posts`.`post_id` AS `id`,
    `posts`.`post_title` AS `title`,
    LEFT(`posts`.`post_body`, 512) AS `preview`,
    `posts`.`post_user` AS `user`,
    DATE_FORMAT(`posts`.`post_date`, '%m-%d-%Y %H:%i:%s') AS `date`,
    `comments`.`total_comments`,
    DATE_FORMAT(`comments`.`last_comment`, '%m-%d-%Y %H:%i:%s') AS `last_comment`
    FROM `posts`
    LEFT JOIN(
    SELECT
    `post_id`,
    COUNT(`comment_id`) AS `total_comments`,
    MAX(`comment_date`) AS `last_comment`
    FROM `comments`
    GROUP BY `post_id`
    ) AS `comments`
    ON `posts`.`post_id` = `comments`.`post_id`
    ORDER BY `posts`.`post_date` DESC";
    $posts = mysql_query($sql);
    $rows = array();
    while (($row = mysql_fetch_assoc($posts)) !== false) {
    $rows[] = array(
    'id' => $row['id'],
    'title' => $row['title'],
    'preview' => $row['preview'],
    'user' => $row['user'],
    'date' => $row['date'],
    'total_comments' => ($row['total_comments'] === null) ? 0 : $row['total_comments'],
    'last_comment' => ($row['last_comment'] === null) ? 'No comment so far (be the first to comment on this post)' : $row['last_comment']
    );
    }
    return $rows;
    }
    //gets a single post from the table
    function get_post($pid) {
    $pid = (int)$pid;
    $sql = "SELECT
    `post_title` AS `title`,
    `post_body` AS `body`,
    `post_user` AS `user`,
    `post_date` AS `date`
    FROM `posts`
    WHERE `post_id` = {$pid}";
    $post = mysql_query($sql);
    $post = mysql_fetch_assoc($post);
    $post['comments'] = get_comments($pid);
    return $post;
    }
    //adds a new blog entry
    function add_post($name, $title, $body) {
    $name = mysql_real_escape_string(htmlentities($name));
    $title = mysql_real_escape_string(htmlentities($title));
    $body = mysql_real_escape_string(nl2br(htmlentities($body)));
    mysql_query("INSERT INTO `posts` (`post_user`, `post_title`, `post_body`, `post_date`) VALUES ('{$name}', '{$title}', '{$body}', NOW())");
    }
    ?>

Appreciate your input

Make sure that header() is above any output.
Eg, don't have HTML content (or text) before header().

EDIT: I have suspicions with the MySQL query on line 69 of posts.inc.php.
Change that line to:

$sql_query_addpost = mysql_query("INSERT INTO `posts` (`post_user`, `post_title`, `post_body`, `post_date`) VALUES ('{$name}', '{$title}', '{$body}', NOW())");

if(!$sql_query_addpost){ echo mysql_error(); die(); }

abcedea wrote:Make sure that header() is above any output.
Eg, don't have HTML content (or text) before header().

EDIT: I have suspicions with the MySQL query on line 69 of posts.inc.php.
Change that line to:

$sql_query_addpost = mysql_query("INSERT INTO `posts` (`post_user`, `post_title`, `post_body`, `post_date`) VALUES ('{$name}', '{$title}', '{$body}', NOW())");

if(!$sql_query_addpost){ echo mysql_error(); die(); }

Checked but still get the same error. I myself think there is a syntax error somewhere in the posts.inc.php file. Couldn't find it yet. Lemme know if you come across other suspicious stuff Thanks

Make sure there are no spaces before the <?php tag and after the ?> tag

ExtremeGaming wrote:Make sure there are no spaces before the <?php tag and after the ?> tag

Thanks. No there is no space before and after the tags.

is this:

header('Location: blog_list.php');

redirecting to itself? Then maybe you don't need it?