BetterPHP

Hey guys,

I have a problem concerning this tutorial,too, so is it okay to use this thread?

My problem is that blog_list.php says:

Warning: mysql_fetch_assoc() expects parameter 1 to be resource, boolean given in C:\xampp\htdocs\blog\core\inc\posts.inc.php on line 38

literally a thousand times before saying:

Fatal error: Maximum execution time of 30 seconds exceeded in C:\xampp\htdocs\blog\core\inc\posts.inc.php on line 38

the concerend line in posts.inc.php is:

while (($row=mysql_fetch_assoc($posts)) !== false){ // <- this line
                 
$rows[]=array(

'id'		=>$row['id'],
'title'		=>$row['title'],
'user'		=>$row['user'],
'date'		=>$row['date'],
'preview'	=>$row['preview'],
'total_comments'=>($row['total_comments']===null) ? 0: $row['total_comments'],
'last_comment'	=>($row['last_comment']===null) ? 'never': $row['last_comment']
                   
);

Can you see the mistake? probably you do

please excuse my awful english and best regards from cologne!

That kind of error usually means that the query is failing for some reason.

If you add a

die(mysql_error());

after the mysql_query() line just above the loop it should tell you why.

Also could you post the SQL here and I will take a look

Thanks for your quick respnonse!

jacek wrote:If you add a

die(mysql_error());

after the mysql_query() line just above the loop it should tell you why.

it does:

No database selected

But i selected it in the init.inc.php, doesen´t i?

<?php
mysql_connect('127.0.0.1', 'blogger', 'blog');
mysql_select_db('blog');

include ('inc/posts.inc.php');
include ('inc/comments.inc.php');
?>

jacek wrote: Also could you post the SQL here and I will take a look

the sql should be the same as in your videos:

<?php
     
function valid_pid($pid){
            $pid = (int)$pid;
           
            $total = mysql_query("SELECT COUNT(`post_id`) FROM `posts` WHERE `post_id` = {$pid}");
            $total = mysql_result($total, 0);
           
            if ($total !=1){
                    return false;
            }else{
                    return true;
            }
    }
     
    function get_posts(){
            $sql = "SELECT
            `posts`.`post_id` AS `id`,
            `posts`.`post_title` AS `title`,
            LEFT(`posts`.`post_body`, 512) AS `preview`, `posts`.`post_user` AS `user`, DATE_FORMAT(`posts`.`post_date`,'%d/%m/%Y %H:%i:%s') AS `date`, `comments`.`total_comments`,
            DATE_FORMAT(`comments`.`last_comment`, '%d/%m/%Y %H:%i:%s') AS `last_comment`
            FROM `posts`
            LEFT JOIN (
            SELECT
                    `post_id`,
                    COUNT(`comment_id`) AS `total_comments`,
                    MAX(`comment_date`) AS `last_comment`
                    FROM `comments`
                    GROUP BY `post_id`
            ) AS `comments`
            ON `posts`.`post_id` = `comments`.`post_id`
            ORDER BY `posts`.`post_date` DESC";
           
            $posts=mysql_query($sql);
           
            $rows = array();
           
            while (($row=mysql_fetch_assoc($posts)) !== false){
                 
				 die(mysql_error());

				 
				$rows[]=array(
				
				'id'		=>$row['id'],
				'title'		=>$row['title'],
				'user'		=>$row['user'],
				'date'		=>$row['date'],
				'preview'	=>$row['preview'],
				'total_comments'=>($row['total_comments']===null) ? 0: $row['total_comments'],
				'last_comment'	=>($row['last_comment']===null) ? 'never': $row['last_comment']
								   
				);
            }
            return $rows;
    }
     

    function get_post($pid){
            $pid=(int)$pid;
           
            $sql = " SELECT
                                    `post_title` AS `title`,
                                    `post_body` AS `body`,
                                    `post_user` AS `user`,
                                    `post_date` AS `date`
                                    FROM `posts`
                                    WHERE `post_id` ={$pid}";
                                   
                    $post=mysql_query($sql);
                    echo mysql_error();
                    $post=mysql_fetch_assoc($post);
                    $post['comments'] = get_comments($pid);
                    return $post;
                   
           
    }
     

    function add_post($name, $title, $body){
           
            $name = mysql_real_escape_string(htmlentities($name));
            $title = mysql_real_escape_string(htmlentities($title));
            $body = mysql_real_escape_string(nl2br(htmlentities($body)));
           
            mysql_query("INSERT INTO `posts` (`post_user`, `post_title`, `post_body`, `post_date`) VALUES ('{$name}', '{$title}', '{$body}', NOW())");
           
    }
     
    ?>

PS: wouldnt it be possible you to upload the files you wrote, which did their job

Ah, when you get "no database selected" after a mysql_select_db() call it means the database didn't exist.

mrcool123 wrote:PS: wouldnt it be possible you to upload the files you wrote, which did their job

No learning that way