BetterPHP

Hi,

I'm a noob here but I have been checking the forums religiously for a while now. I'm a CS student taking a PHP/Mysql course so I'm coding everything I can possibly get my hands on and am using the tutorial as a way to learn more about PHP and Mysql. I've taken a look at similar problems on the forum and despite that, have not determined the problem with my code. I have also used echo_mysql error(); under the SQL query that is not working but it just does the same thing. The error message says:

Warning: mysql_fetch_assoc() expects parameter 1 to be resource, boolean given in C:\wamp\www\blog_practice\core\inc\posts.inc.php on line 42

Here's the code:

<?php

// checks if the given post id is in the table.
function valid_pid($pid){
	$pid = (int)$pid;
	
	$total = mysql_query("SELECT COUNT(`post_id`) FROM `posts` WHERE `post_id` = {$pid}");
	$total = mysql_query($total, 0);
	
	if ($total !=1){
		return false;
	}else{
		return true;
	}
}

// fetches a summary of all the blog posts.
function get_posts(){
	$sql = "SELECT
				`posts` . `post_id` AS `id`,
				`posts` . `post_title` AS `title`,
				LEFT(`posts` . `post_body`, 512) AS `preview`,
				`posts` . `post_user` AS `user`,
				DATE_FORMAT(`posts` . `post_date`,'%d/%m/%Y %H:%i:%s') AS `date`,
				`comments` . `total_comments`,
				DATE_FORMAT(`comments` . `last_comment`, '%d/%m/%Y %H:%i:%s') AS `last_comment`
			FROM `posts`
			LEFT JOIN(
				SELECT
				`post_id`,
					COUNT(`comment_id`) AS `total_comments`,
					MAX(`comment_date`) AS `last_comment`
				FROM `comments`
				GROUP BY `post_id`
			) AS `comments`
			ON `posts` . `post_id` = `comments` . `post_id`
			ORDER BY `posts` . `post_date` DESC";
			
	$posts = mysql_query($sql);	
	
	$rows = array();
	while (($row = mysql_fetch_assoc($posts)) !== false){
		$rows[] = array(
			'id'				=> $row['id'],
			'title'				=> $row['title'],
			'preview'			=> $row['preview'],
			'user'				=> $row['user'],
			'date'				=> $row['date'],
			'total_comments'	=> ($row['total_comments'] === null) ? 0 : $row['total_comments'],
			'last_comment'		=> ($row['last_comment'] === null) ? 'never' : $row['last_comment']
		);
	}

	return $rows;
}

// fetches a single post from the table.	
function get_post($pid){
	$pid = (int)$pid;
	
	$sql = "SELECT
				`post_title` AS `title`,
				`post_body` AS `body`,
				`post_user` AS `user`,
				`post_date` AS `date`
			FROM `posts`
			WHERE `post_id` = {$pid}";
	
	$post = mysql_query($sql);
	$post = mysql_fetch_assoc($post);
	$post['comment'] = get_comments($pid);
	
	return $post;
}

//adds a new blog entry
function add_post($name, $title, $body){
	$name = mysql_real_escape_string(htmlentities($name));
	$title = mysql_real_escape_string(htmlentities($title));
	$body = mysql_real_escape_string(nl2br(htmlentities($body)));
	
	mysql_query("INSERT INTO `posts' (`post_user`, `post_title`, `post_body`, `post_date`) VALUES ('{$name}', '{$title}', '{$body}', NOW())");
}

?>

Any help would be much appreciated.

That usually means your query is failing for some reason, when that happens mysql_query() will return false (a boolean, an unexpected one). You can get the server to tell you want went wrong by adding

echo mysql_error();

after the mysql_query() line. It's usually just a typo of a column name or something.

It was exactly as you said: a typo. Ahahaha, I feel silly. Thanks Jacek!

emilysanders wrote:It was exactly as you said: a typo. Ahahaha, I feel silly. Thanks Jacek!

They can be really hard to spot

No problem